Skip to content

Bump version to 2.9.5 (2241) - #768

Closed
lukhnos wants to merge 1 commit into
openvanilla:masterfrom
lukhnos:bump-version
Closed

Bump version to 2.9.5 (2241)#768
lukhnos wants to merge 1 commit into
openvanilla:masterfrom
lukhnos:bump-version

Conversation

@lukhnos

@lukhnos lukhnos commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 5, 2026 16:56

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the app version to 2.9.5 and the build number to 2241. The changes correctly update the version numbers in both Installer-Info.plist and McBopomofo-Info.plist. However, I've identified a maintainability issue with version numbers being hardcoded in multiple places. My review includes suggestions to centralize version management using Xcode's build settings to prevent potential inconsistencies in the future. This would make the release process more robust.

Comment thread Source/Installer/Installer-Info.plist
Comment thread Source/McBopomofo-Info.plist

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the application version from 2.9.4 (build 2186) to 2.9.5 (build 2241), updating version identifiers across the main application and installer bundles.

  • Updated CFBundleShortVersionString from 2.9.4 to 2.9.5
  • Updated CFBundleVersion from 2186 to 2241

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Source/McBopomofo-Info.plist Updated version strings for the main input method application bundle
Source/Installer/Installer-Info.plist Updated version strings for the installer application bundle

@lukhnos
lukhnos marked this pull request as draft January 5, 2026 21:49
@lukhnos

lukhnos commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

We'll need to bump version after the recently discovered regression is fixed.

@lukhnos lukhnos closed this Jan 5, 2026
@lukhnos
lukhnos deleted the bump-version branch January 6, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants