Skip to content

Fix scroll-to-0 regression in vertical panel #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonble merged 1 commit into from
Jan 6, 2026
Merged

Fix scroll-to-0 regression in vertical panel #770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Packages/CandidateUI/Sources/CandidateUI/VerticalCandidateController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,8 @@ public class VerticalCandidateController: CandidateController {
let selectedRow = tableView.selectedRow
let pageIndex = newRowIndex / labelCount

if selectedRow == -1 || abs(newRowIndex - selectedRow) == 1 {
// Simply scroll to the row if never selected or if it's moving by one.
if selectedRow == -1 || newRowIndex == 0 || abs(newRowIndex - selectedRow) == 1 {
// Simply scroll to the row if never selected, if to row 0, or if it's moving by one.
tableView.scrollRowToVisible(newRowIndex)
Comment thread
lukhnos marked this conversation as resolved.
} else {
if newRowIndex > selectedRow {
Expand Down