Skip to content

Add new entries for '嫆', '斈', '𢻯', '斅', and '斆' in BPMFBase.txt - #836

Merged
lukhnos merged 2 commits into
openvanilla:masterfrom
zonble:phrase
Jun 2, 2026
Merged

Add new entries for '嫆', '斈', '𢻯', '斅', and '斆' in BPMFBase.txt#836
lukhnos merged 2 commits into
openvanilla:masterfrom
zonble:phrase

Conversation

@zonble

@zonble zonble commented May 27, 2026

Copy link
Copy Markdown
Contributor

Fix for #835

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加字的話,phrase.occ 應該也要有對應條目(例如 #825 )?不然詞庫編譯工具只會給 -99.0 的對數頻率,這樣字的字頻反而比 emoji 還低

@zonble

zonble commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

加字的話,phrase.occ 應該也要有對應條目(例如 #825 )?不然詞庫編譯工具只會給 -99.0 的對數頻率,這樣字的字頻反而比 emoji 還低

Updated at 2bc8f8c

@mjhsieh

mjhsieh commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

sorry I merged #840

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing entry in phrase.occ it seems. Otherwise LGTM. :)

Comment thread Source/Data/phrase.occ

@lukhnos lukhnos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lukhnos
lukhnos merged commit b4bd120 into openvanilla:master Jun 2, 2026
9 checks passed
@zonble zonble mentioned this pull request Jun 2, 2026
3 tasks
@zonble
zonble deleted the phrase branch July 17, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants