Fix data checker by forcing LC_ALL=C - #837
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Source/Data/Makefile to export LC_ALL=C for the check target, ensuring consistent locale behavior during the execution of the check commands. There are no review comments, and I have no additional feedback to provide.
lukhnos
added a commit
to lukhnos/McBopomofo
that referenced
this pull request
May 31, 2026
"崐" from openvanilla#833 "𡻈" from openvanilla#75 Those are the only two characters with score -99.0. For 𡻈 it's problematic because it's ranked lower than the emoji 🪡 because of it. Also fixes the `sort` Makefile recipe based on how the issue was fixed in openvanilla#837 Also updates the byte length in `check` from 3 to 4, because "𡻈" is actually 4 bytes long in UTF-8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes our data checker, which has apparently been broken for quite a while...
When
LC_ALLis not explicitly set, the default locale is usually something likeen_US.UTF-8. Under that locale,sort -umay collapse many CJK strings into the same collation group, which meansmake checkunderDatawas basically failing to catch real differences : )Since #833 added new entries without adding them to
phrase.occ, causing the check to fail. I discovered this while preparing another PR, because GitHub Actions started failing on themacos-15-arm64 20260527.0100.1runner image. It may have changed some locale settings or tool versions.