Add new entries for '𰻝', '𰻞', and '𰻞𰻞麵' in BPMFBase.txt and phrase.occ - #853
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
…8 support The `make check`used to suppose that every chinese character is composed by 3 bytes when it is utf8 encoding. However, 𰻝 has 4 bytes.
lukhnos
requested changes
Jun 25, 2026
lukhnos
left a comment
lukhnos
left a comment
Contributor
There was a problem hiding this comment.
Looking at Makefile again, I wonder if some changes are warranted. See my comment.
lukhnos
requested changes
Jun 25, 2026
lukhnos
left a comment
lukhnos
left a comment
Contributor
There was a problem hiding this comment.
Left a comment re the use of gawk.
…and to use Python script for validation
lukhnos
requested changes
Jun 26, 2026
lukhnos
left a comment
lukhnos
left a comment
Contributor
There was a problem hiding this comment.
Overall LGTM, but check.py doesn't seem to exit with non-0 if it finds issues?
| @awk '{print $$2,$$3,$$4,$$5,$$6,$$7}' BPMFMappings.txt | awk '/一/' | ||
| @diff -u <(awk '{print $$1}' BPMFMappings.txt|sort -u) \ | ||
| <(awk 'length($$1)>4{print $$1}' phrase.occ|sort -u) | ||
| @python3 scripts/check.py |
Contributor
There was a problem hiding this comment.
But if check.py finds anything incorrect, does it end the program with a non-0 exit code?
… of printing them directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://zh.wikipedia.org/zh-tw/%F0%B0%BB%9E%F0%B0%BB%9E%E9%BA%B5