Fix Hsu and ETen26 out-of-order sequence handling - #871
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Bopomofo keyboard layout logic in Mandarin.h to handle out-of-order typing sequences for Hsu and ETen26 layouts. When the existing syllable contains only a vowel and the next character has multiple possibilities with the second also being a vowel, the engine now correctly falls back to the consonant. Unit tests have been added in MandarinTest.cpp to verify this idempotent sequence behavior. There are no review comments, so no further feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
d6b8fa1 to
e7dc242
Compare
lukhnos
changed the title
a846f86 to
5ede854
Compare
5ede854 to
32963a6
Compare
Certain sequences should have the equivalent output, such as ai/ia with Hsu (both should yield ㄘㄞ). While "ia" might be a mistake on the user's part, since it is the equivalent of "ai", the layout code still should honor it.
32963a6 to
e3dab67
Compare
2 participants
Certain sequences should have the equivalent output, such as ai/ia with Hsu (both should yield ㄘㄞ). While "ia" might be a mistake on the user's part, since it is the equivalent of "ai", the layout code still should honor it.
This issue was discovered via #870.