Improve the usability of the analysis script - #875
Conversation
300fa7f to
a68f5ad
Compare
There was a problem hiding this comment.
Code Review
This pull request integrates the language model analysis script into the curation package as curation.analyzers.find_cover_issues and introduces a utility module curation.utils.lmreader for reading LM files. It also updates the Makefile to include targets for formatting, typechecking, and running the analysis. The review feedback highlights three critical issues: a slicing bug when cutoff is set to -1 (unlimited), a copy-paste error using len(insufficients) instead of len(indifferents) in the indifferent section, and a potential IndexError along with a missing f-string interpolation in lmreader.py.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- Introduce `make analyze` to run the analyzer - Move the analyzer to curation/analyzers/ - Improve the UI/UX of the analysis report
a68f5ad to
eab82e6
Compare
Now if you type
make analyze, you will see a report like this (I'm usingmake ANALYZE_LIMIT=10 analyzeto make the report shorter):