Fix builder formula error and improve coverage - #891
Merged
Conversation
Also reduce the entries in Postprocess.txt after the fix. Fixes openvanilla#889
This was referenced Aug 5, 2026
Contributor
|
LGTM |
zonble
approved these changes
Aug 6, 2026
ChiahongHong
reviewed
Aug 6, 2026
| print("({})".format(e)) | ||
| for k in phrases: | ||
| if phrases[k] < 1: | ||
| handle.write('%s %.8f\n' % (k, math.log(fscale ** (len(k) / 3 - 1) * 0.5 / norm, 10))) |
Contributor
There was a problem hiding this comment.
因為這幾天有點忙，我其實也做一些額外的檢查但還沒做完，所以才沒回覆您在 #889 提到的 make analyze
我的筆電不在身邊沒辦法驗證，用手機很難操作 GitHub 所以我先留個言。您提到的 6% （或是筆數，我記得我的結果是 8 千多筆）印象中跟我前天跑的不太一樣，主因是這兩處可能也要改
Contributor
Author
There was a problem hiding this comment.
感恩。發了 #891 ，不過 make analyze 的結果沒有變（一樣是 14,209 條被覆蓋的詞）。這要麻煩你有空的時候再驗證看看了。
Contributor
There was a problem hiding this comment.
抱歉 6% 跟 8 千多筆是我記錯了，因為我認為統計方式需要調整，所以忘記我改過 find_cover_issues.py ，自然結果數值不同。現在我的計算方式統計出來的值又有不同，已經更新在 #889，之後要找比較好找。
ChiahongHong
reviewed
Aug 6, 2026
| if phrases[k] < 1: | ||
| handle.write('%s %.8f\n' % (k, math.log(fscale ** (len(k) / 3 - 1) * 0.5 / norm, 10))) | ||
| else: | ||
| handle.write('%s %.8f\n' % (k, math.log(fscale ** (len(k) / 3 - 1) * phrases[k] / norm, 10))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reduce the entries in Postprocess.txt after the fix.
Fixes #889
@ChiahongHong PTAL.