Sync engine source with upstream - #242
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the shortest path computation to use the Viterbi algorithm, which is a great improvement for this type of problem. The implementation is mostly correct, but I've found a critical issue that could lead to a crash if no valid segmentation path is found for a given input. I've also suggested a performance optimization for the Viterbi loop to avoid processing unreachable states. Addressing these points will make the implementation more robust and efficient.
zonble
approved these changes
Mar 1, 2026
Contributor
|
Thanks for porting this to Linux! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches to use the Viterbi algorithm to compute the shortest path.
See openvanilla/McBopomofo#777