Skip to content

Solve issue Update hashcat mode with new rules #5905#5965

Open
Serax4 wants to merge 2 commits intoopenwall:bleeding-jumbofrom
Serax4:patch-1
Open

Solve issue Update hashcat mode with new rules #5905#5965
Serax4 wants to merge 2 commits intoopenwall:bleeding-jumbofrom
Serax4:patch-1

Conversation

@Serax4
Copy link
Copy Markdown

@Serax4 Serax4 commented Mar 19, 2026

Added the options requested
#5905
I did not add option S because we had it already and I wasn't sure about option v so i skipped it as well.

Copy link
Copy Markdown
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested each mnemonic and they work fine. However, it seems to me you messed up the indentation. In particular, the old code for '1' and '2' now has an additional tab of indentation. You shouldn't touch existing code. Also, your case lines (only that one line for each case) for 'H' and 'B' have one tab too much.

You would be able to implement the 'v' rule if you like (would be much appreciated) if you use the hc_logic variable (see the code for 'p' rule, and doc/RULES-hashcat).

Copy link
Copy Markdown
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't touch old/unrelated code (some formatting was still changed). I know the old code doesn't comply with current coding standards so what you did was right in a way but things like that should be in some other commit and PR.

Worse, case 'v' doesn't even build. It clashes with the existing one. Could you build and run it?

rules.c: In function 'rules_apply':
rules.c:1479:17: error: duplicate case value
 1479 |                 case 'v':
      |                 ^~~~
rules.c:1426:17: note: previously used here
 1426 |                 case 'v': /* assign value to numeric variable */
      |                 ^~~~
make[1]: *** [rules.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [default] Error 2

To make it work, this new code needs to be inside the existing 'v' case (with if (hc_logic) .. else). See case 'p' for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants