Skip to content

Weekly Dependabot Updates 20260525#3146

Closed
swcurran wants to merge 1 commit into
openwallet-foundation:mainfrom
swcurran:weekly-update
Closed

Weekly Dependabot Updates 20260525#3146
swcurran wants to merge 1 commit into
openwallet-foundation:mainfrom
swcurran:weekly-update

Conversation

@swcurran

Copy link
Copy Markdown
Contributor

Attempting the weekly update. The instructions are not yet clear to me. Here is what I did and questions:

  1. Created a branch.
  2. Ran the repo_manager option 6.
  3. Submitted the PR

Is there anything else that should be done? Are there more complex versions of the update process? For example, in this case, all of the dependabot PRs only update the poetry.lock files -- but what if the pyproject.toml files need to be updated?

Also, I notice that #3132 updates 10 lock files across the repo. Could we have used that?

I haven't gotten to the closing yet. Want to see if this worked before I do that.

Signed-off-by: Stephen Curran swcurran@gmail.com

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
swcurran requested a review from jamshale May 25, 2026 16:14
@jamshale

Copy link
Copy Markdown
Contributor

Yes. We could have used #3132 this time. I don't know what's going on with the dependabot grouping. Usually it doesn't work correctly and then sometimes it does.

In general you shouldn't really need to change pyproject.toml files unless you want to change the minor/major upgrade range.

I usually just use the python repo_manager 7 idna for example. This will target the individual library instead of a general update of all libraries.

Then you can use python repo_manager.py 8 <lower> <upper> to close a range of PR's to clean up the list of PR's.

@swcurran

Copy link
Copy Markdown
Contributor Author

@jamshale -- you didn't approve this PR. Does that mean I should close it and try again targeting the idna library?

@swcurran

Copy link
Copy Markdown
Contributor Author

Also, doesn't it make sense to always update all of the lock files, so all of the dependencies get updated?

Also, how does something like ruff get updated -- references to things not covered by the lock file updates. For example, from this weekly upgrade when ruff and pytest got updated across the board.

@jamshale

jamshale commented May 25, 2026

Copy link
Copy Markdown
Contributor

This PR didn't actually upgrade the libraries if you look at the lock files. I think option6 might be broken after the major poetry version that happened a while ago. It used to upgrade all libraries that could be upgraded which is more than needed and usually broke automated testing.

Option 7 works because it goes through every project and targets the specific library you define. I use this for upgrading ruff which has regular updates. The PR you linked was one where I manually did the major upgrade of pytest.

I think we can either close this PR and approve a merge #3132 this week or it can have option 7 targeting idna applied to this PR and then we can merge it.

@swcurran

Copy link
Copy Markdown
Contributor Author

Wow...very weird. OK. I'll try again.

@swcurran swcurran closed this May 25, 2026
@swcurran
swcurran deleted the weekly-update branch May 25, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants