Add unsecure credential storage option - #3824
Closed
PatStLouis wants to merge 11 commits into
Closed
Conversation
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
|
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
…-cloudagent-python into store-unsecure-credentials
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137
reviewed
Jul 22, 2025
ff137
left a comment
ff137
left a comment
Member
There was a problem hiding this comment.
Please only mark ready / tag for review when PR tests are passing. Because it gives a GitHub notification for each new commit. And if I see tests aren't passing, then I know it's not ready to merge / not ready for review.
Contributor
|
FYI, if you didn't realize. We fail the test run for most warnings. There is a few of them that need to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to store a W3C VC without verifying it's proof on the
/vc/credentials/storeendpoint.This option will default to true, and can be turned off (unsecured) for experimenting with unsupported cryptosuites and/or did methods.
The DataModel will still be validated, this only affects the proof verification step.