Skip to content

feat: CredentialDetails custom subheader component#1882

Merged
MacDeluca merged 4 commits into
openwallet-foundation:mainfrom
MacDeluca:md_4236_cred_header
Jul 16, 2026
Merged

feat: CredentialDetails custom subheader component#1882
MacDeluca merged 4 commits into
openwallet-foundation:mainfrom
MacDeluca:md_4236_cred_header

Conversation

@MacDeluca

@MacDeluca MacDeluca commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

This PR adds a custom subheader component for the CredentialDetails screen.

Testing Instructions

Replace this text with detailed instructions on how to test the changes included in this PR.

Acceptance Criteria

Replace this text with the acceptance criteria that must be met for this PR to be approved.

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
@MacDeluca
MacDeluca requested a review from a team as a code owner July 16, 2026 19:50
@changeset-bot

changeset-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 367fb16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@bifold/core Patch
@bifold/remote-logs Patch
@bifold/oca Patch
@bifold/react-hooks Patch
@bifold/react-native-attestation Patch
@bifold/verifier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
Signed-off-by: Mac Deluca <Mac.Deluca@quartech.com>
@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.96%. Comparing base (5aa0743) to head (367fb16).

Files with missing lines Patch % Lines
packages/core/src/utils/helpers.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1882   +/-   ##
=======================================
  Coverage   59.95%   59.96%           
=======================================
  Files         341      341           
  Lines       11898    11899    +1     
  Branches     3380     3380           
=======================================
+ Hits         7134     7135    +1     
+ Misses       4728     4708   -20     
- Partials       36       56   +20     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MacDeluca
MacDeluca marked this pull request as draft July 16, 2026 21:11
@MacDeluca
MacDeluca marked this pull request as ready for review July 16, 2026 21:35
@sonarqubecloud

Copy link
Copy Markdown

@MacDeluca
MacDeluca merged commit 3dee0f8 into openwallet-foundation:main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants