Miigrate codelab from v0.96 to v0.97#73
Merged
TheBlackBit merged 5 commits intoopenwallet-foundation:mainfrom Mar 2, 2026
Merged
Miigrate codelab from v0.96 to v0.97#73TheBlackBit merged 5 commits intoopenwallet-foundation:mainfrom
TheBlackBit merged 5 commits intoopenwallet-foundation:mainfrom
Conversation
added 2 commits
February 25, 2026 12:57
…gic.
- Upgrade `multipaz` to `0.97.0` and `ktor` to `3.1.0`.
- Update Android `jvmTarget` to `JVM_17`.
- **Removed `NfcActivity.kt`**: Proximity presentment logic is now handled by generic activities and services.
- **Introduced `NfcService.kt`**: New `MdocNdefService` implementation that resets the `PresentmentActivity.presentmentModel` with the current `presentmentSource`.
- **Refactored `NdefService.kt`**: Simplified to use `PresentmentActivity` components and injected dependencies instead of manual initialization.
- **Updated `AccountScreen.kt`**:
- Migration to the new `MdocProximityQrPresentment` composable.
- Added UI handling for different presentment states: `showTransacting` and `showCompleted`.
- Integrated `AppSettingsModel` to dynamically configure BLE (Central/Peripheral/L2CAP) and NFC connection methods.
- **Updated `CredmanActivity.kt`**: Simplified settings by delegating more responsibilities to the base `CredentialManagerPresentmentActivity`.
- Replaced `DigitalCredentials.Default` with `DigitalCredentials.getDefault()`.
- Renamed `startExportingCredentials` to `register`.
- Updated `AppSettingsModel` to initialize `dcApiProtocols` using the new `DigitalCredentials` instance.
- **Provisioning Refactor**: Updated `ProvisioningModel` to use `DocumentProvisioningHandler` and removed inline `documentMetadataInitializer` in favor of a cleaner initialization flow.
- **`OpenID4VCILocalBackend`**: Updated to use `CredentialKeyAttestation` instead of `KeyIdAndAttestation`.
- **Koin Modules**: Added `AppSettingsModel` to the DI module and cleaned up `PresentmentModel` and `PresentmentSource` providers.
- **Document Store**: Updated `hasAnyUsableCredential` extension to use `documentId.identifier`.
Signed-off-by: Ever Morales <ever.morales@koombea.com>
Signed-off-by: Ever Morales <ever.morales@koombea.com>
TheBlackBit
changed the title
Signed-off-by: Ever Morales <ever.morales@koombea.com>
VishnuSanal
requested changes
Feb 27, 2026
Member
VishnuSanal
left a comment
VishnuSanal
left a comment
There was a problem hiding this comment.
great work Ever, please take a look at the comments. thanks!
...oseApp/src/commonMain/kotlin/org/multipaz/samples/wallet/cmp/util/DocumentStoreExtensions.kt
Outdated
Show resolved
Hide resolved
...delab/Holder/composeApp/src/androidMain/kotlin/org/multipaz/samples/wallet/cmp/NfcService.kt
Outdated
Show resolved
Hide resolved
Member
|
hi @TheBlackBit from my testing web verification fails on Android - can you please take a look, thanks! |
added 2 commits
February 27, 2026 12:05
Signed-off-by: Ever Morales <ever.morales@koombea.com>
Simplified the `hasAnyUsableCredential` function by removing the redundant `lookupDocument` call and directly checking the first document from the list. Signed-off-by: Ever Morales <ever.morales@koombea.com>
VishnuSanal
changed the title
VishnuSanal
approved these changes
Mar 2, 2026
Contributor
Author
Totally, can you please create it and assign to me please |
TheBlackBit
added a commit
to TheBlackBit/multipaz-samples
that referenced
this pull request
Apr 13, 2026
* Upgrade multipaz to 0.97 and refactor presentment and provisioning logic.
- Upgrade `multipaz` to `0.97.0` and `ktor` to `3.1.0`.
- Update Android `jvmTarget` to `JVM_17`.
- **Removed `NfcActivity.kt`**: Proximity presentment logic is now handled by generic activities and services.
- **Introduced `NfcService.kt`**: New `MdocNdefService` implementation that resets the `PresentmentActivity.presentmentModel` with the current `presentmentSource`.
- **Refactored `NdefService.kt`**: Simplified to use `PresentmentActivity` components and injected dependencies instead of manual initialization.
- **Updated `AccountScreen.kt`**:
- Migration to the new `MdocProximityQrPresentment` composable.
- Added UI handling for different presentment states: `showTransacting` and `showCompleted`.
- Integrated `AppSettingsModel` to dynamically configure BLE (Central/Peripheral/L2CAP) and NFC connection methods.
- **Updated `CredmanActivity.kt`**: Simplified settings by delegating more responsibilities to the base `CredentialManagerPresentmentActivity`.
- Replaced `DigitalCredentials.Default` with `DigitalCredentials.getDefault()`.
- Renamed `startExportingCredentials` to `register`.
- Updated `AppSettingsModel` to initialize `dcApiProtocols` using the new `DigitalCredentials` instance.
- **Provisioning Refactor**: Updated `ProvisioningModel` to use `DocumentProvisioningHandler` and removed inline `documentMetadataInitializer` in favor of a cleaner initialization flow.
- **`OpenID4VCILocalBackend`**: Updated to use `CredentialKeyAttestation` instead of `KeyIdAndAttestation`.
- **Koin Modules**: Added `AppSettingsModel` to the DI module and cleaned up `PresentmentModel` and `PresentmentSource` providers.
- **Document Store**: Updated `hasAnyUsableCredential` extension to use `documentId.identifier`.
* Code formatted
* Remove NfcActivity from AndroidManifest.xml.
Signed-off-by: Ever Morales <ever.morales@koombea.com>
* Delete unused NfcService.kt
* Refactor hasAnyUsableCredential in DocumentStoreExtensions
Simplified the `hasAnyUsableCredential` function by removing the redundant `lookupDocument` call and directly checking the first document from the list.
---------
Signed-off-by: Ever Morales <ever.morales@koombea.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/Addresses
Fixes/Addresses #1593
What does this PR do?
Migrate codelab to v0.97
Why are we making this change?
The Multipaz library has released the version v0.97 so we have to migrate our codelab to v0.97
How was this tested?
Checklist