Properly handle path-based claims.#1026
Merged
Merged
Conversation
davidz25
force-pushed
the
sdjwt-path-and-dc-tests
branch
from
June 6, 2025 22:20
f7903c6 to
edb4541
Compare
Other changes: - Use "JSON-Based" instead of "W3C VC" or "VC" since that's a lot more accurate and also in line with what OpenID Foundation standards are doing. This includes renaming a bunch of types, methods, params, and comments. - Also register for `TYPE_DIGITAL_CREDENTIAL` to make things work with X-device presentment in Chrome. - Add unit tests in `DigitalCredentialsPresentmentTest` for mDL and SD-JWT VC presentment using OpenID4VP draft 24. This is just the beginning, we'll add a lot more tests once we integrate the new DCQL library. Test: ./gradlew check && ./gradlew connectedCheck Test: New unit tests and all unit tests pass. Test: Manually tested with own and 3rd party verifiers. Signed-off-by: David Zeuthen <zeuthen@google.com>
davidz25
force-pushed
the
sdjwt-path-and-dc-tests
branch
from
June 6, 2025 22:22
edb4541 to
c8709b5
Compare
sorotokin
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other changes:
TYPE_DIGITAL_CREDENTIALto make things work with X-device presentment in Chrome.DigitalCredentialsPresentmentTestfor mDL and SD-JWT VC presentment using OpenID4VP draft 24. This is just the beginning, we'll add a lot more tests once we integrate the new DCQL library.Test: ./gradlew check && ./gradlew connectedCheck
Test: New unit tests and all unit tests pass.
Test: Manually tested with own and 3rd party verifiers.