Skip to content

Update DEVELOPER-ENVIRONMENT.md#1061

Merged
davidz25 merged 1 commit into
openwallet-foundation:mainfrom
hanluOMH:main
Jun 13, 2025
Merged

Update DEVELOPER-ENVIRONMENT.md#1061
davidz25 merged 1 commit into
openwallet-foundation:mainfrom
hanluOMH:main

Conversation

@hanluOMH

@hanluOMH hanluOMH commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Add more steps to set up build env in mac

Fixes #1002

Add more steps about install the right version of xcode and set to default Xcode and also tell developer to add developerID

  • Tests pass
  • Appropriate changes to README are included in PR

@hanluOMH
hanluOMH requested a review from davidz25 June 9, 2025 21:16

@davidz25 davidz25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, lots of small nits in my review... and sorry for being pedantic about whitespace changes but it's one of those things I get excited about 😄

Comment thread DEVELOPER-ENVIRONMENT.md Outdated
Comment thread DEVELOPER-ENVIRONMENT.md
Comment thread DEVELOPER-ENVIRONMENT.md Outdated
Comment thread DEVELOPER-ENVIRONMENT.md Outdated
Comment thread DEVELOPER-ENVIRONMENT.md Outdated
@hanluOMH

Copy link
Copy Markdown
Contributor Author

Thanks , all feedback is resolved, please check it.

@davidz25

Copy link
Copy Markdown
Contributor

Thanks. Please squash the commits together to 1 (as per the CONTRIBUTING.md file) and we can land this!

Add more steps to set up build env in mac

Signed-off-by: hanluOMH <hanlu@openmobilehub.com>

Update DEVELOPER-ENVIRONMENT.md

Add more steps to set up build env in mac

Signed-off-by: hanluOMH <hanlu@openmobilehub.com>
@hanluOMH

hanluOMH commented Jun 12, 2025

Copy link
Copy Markdown
Contributor Author

Thanks. Please squash the commits together to 1 (as per the CONTRIBUTING.md file) and we can land this!
Thanks @davidz25 , the sqush the commits. Please check it.

@davidz25
davidz25 merged commit eadb873 into openwallet-foundation:main Jun 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't generate ios app

2 participants