Selfie Check and Capture Use case#1062
Conversation
b027d41 to
5a03c32
Compare
|
I have problems building your branch since I updated to a more recent version of XCode. If you could rebase to tip-of-tree that'd be nice (in general it's a good idea to do that before every PR push, your branch is currently 8 commits behind). Also, PR #1102 also adds a function to encode a PNG from an |
ec04a9d to
16636ee
Compare
|
This looks very good! A couple of minor suggestions / nitpicks!
As for colors, I noticed that we're hardcoding some colors and that might be fine... but would it make sense to use it from |
|
|
||
| val cgImage = CGBitmapContextCreateImage(context) | ||
| return cgImage?.let { UIImage.imageWithCGImage(it) } | ||
| } |
There was a problem hiding this comment.
Should this be internal / private?
There was a problem hiding this comment.
No. That's the Compose.Util class. It's used in faceDetector module. We decided to consolidate useful iOS graphics tools in Compose module during the last week review.
7316e1b to
b6ea92c
Compare
Test: All Unit tests are passing (bar KI). Test: Manually tested via samples/testapp on Android and iOS. Signed-off-by: koukarine <koukarine@google.com>
davidz25
left a comment
There was a problem hiding this comment.
LGTM, thanks for all your work on this!
Implement Selfie Check and capture flow.
Tests: manually verify happy and unhappy paths using TestApp on Android and iOS.
Ticket: #1071