[#73373] Background job for migrating pre-existing data to semantic identifiers

app/controllers/admin/settings/work_packages_identifier_controller.rb

@@ -43,17 +43,10 @@ def show
     end
 
     def update
-      return render_400 unless params[:settings]
-
-      if autofix_requested?
-        call = update_service.new(user: current_user).call(settings_params)
-        call.on_success do
-          WorkPackages::IdentifierAutofix::ApplyHandlesJob.perform_later
-          redirect_to action: "show"
-        end
-        call.on_failure { failure_callback(call) }
-      else
-        super
+      case params.dig(:settings, :work_packages_identifier)
+      when Setting::WorkPackageIdentifier::SEMANTIC  then switch_to_semantic
+      when Setting::WorkPackageIdentifier::CLASSIC   then switch_to_classic
+      else                                                render_400
       end
     end
 
@@ -74,12 +67,21 @@ def status
 
     private
 
+    def switch_to_semantic
+      ProjectIdentifiers::ConvertInstanceToSemanticIdsJob.perform_later unless WorkPackages::IdentifierAutofix.job_in_progress?
+      redirect_to action: "show"
+    end
+
+    def switch_to_classic
+      call = Settings::UpdateService.new(user: current_user)
+                                    .call(work_packages_identifier: Setting::WorkPackageIdentifier::CLASSIC)
+      call.on_success { redirect_to action: "show" }
+      call.on_failure { render_400 }
+    end
+
     def check_feature_flag
       render_404 unless OpenProject::FeatureDecisions.semantic_work_package_ids_active?
     end
 
-    def autofix_requested?
-      ActiveRecord::Type::Boolean.new.cast(params[:confirm_dangerous_action])
-    end
   end
 end

app/models/projects/semantic_identifier.rb

@@ -51,6 +51,21 @@ def allocate_wp_semantic_identifier!
     [seq, "#{identifier}-#{seq}"]
   end
 
+  # Returns the most-recent slug from FriendlyId history that is a valid semantic
+  # identifier and is not currently held by another project, or nil if none exists.
+  # Used by the backfill job to restore a prior semantic identifier instead of
+  # generating a fresh one, so existing WP identifiers and aliases remain correct.
+  def previous_semantic_identifier
+    detector = WorkPackages::IdentifierAutofix::ProblematicIdentifiers.new
+    slugs
+      .order(created_at: :desc)
+      .pluck(:slug)
+      .find do |slug|
+        detector.format_error_reason(slug).nil? &&
+          !self.class.where.not(id:).exists?(identifier: slug)
+      end
+  end
+
   # Called after this project's identifier is renamed. Atomically:
   # 1. Appends new-prefix aliases for every WP that ever carried an old-prefix alias.
   # 2. Updates identifier on resident WPs to the new prefix.

app/models/setting/work_package_identifier.rb

@@ -36,5 +36,6 @@ module WorkPackageIdentifier
 
     def self.semantic? = Setting[:work_packages_identifier] == SEMANTIC
     def self.classic?  = Setting[:work_packages_identifier] == CLASSIC
+    def self.enable_semantic! = Setting.work_packages_identifier = SEMANTIC
   end
 end

app/models/work_package/semantic_identifier.rb

@@ -93,8 +93,6 @@ def allocate_and_register_semantic_id
     end
   end
 
-  private
-
   # Builds alias rows for every identifier this project has ever used at the given sequence (including the current one).
   # This also includes "ghost identifiers" -- i.e. those that weren't ever actually generated, but should work
   # as a historical alias (e.g. OLDPROJ-42 should work even if WP #42 was created after rename to NEWPROJ)

app/models/work_package_semantic_alias.rb

@@ -42,4 +42,8 @@ class WorkPackageSemanticAlias < ApplicationRecord
 
   validates :identifier, presence: true, uniqueness: true
   validates :work_package, presence: true
+
+  def self.upsert_rows(rows)
+    insert_all(rows, unique_by: :identifier) if rows.any?
+  end
 end

app/services/project_identifiers/backfill_project_service.rb

@@ -0,0 +1,105 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module ProjectIdentifiers
+  # Brings a single project fully up to date for semantic identifier mode:
+  #
+  # 1. Fixes the project identifier if it is not in valid semantic format.
+  # 2. Syncs the sequence counter so it is >= any existing sequence_number
+  #    (guards against counter underflow caused by cross-project WP moves).
+  # 3. Rewrites stale WP identifiers whose prefix no longer matches the project.
+  # 4. Assigns sequence numbers to WPs that have none yet.
+  # 5. Seeds the alias table for all historical project identifier prefixes.
+  class BackfillProjectService
+    def initialize(project)
+      @project = project
+    end
+
+    def call
+      fix_identifier_if_needed
+      reset_stale_identifiers
+      backfill_missing_ids
+      seed_alias_table
+    end
+
+    private
+
+    attr_reader :project
+
+    def fix_identifier_if_needed
+      detector  = WorkPackages::IdentifierAutofix::ProblematicIdentifiers.new
+      generator = WorkPackages::IdentifierAutofix::ProjectIdentifierSuggestionGenerator
+      # Pure format check — no DB queries. nil means the identifier is fine.
+      return unless detector.format_error_reason(project.identifier)
+
+      # Prefer restoring the project's last known semantic identifier (from FriendlyId history)
+      # so that existing WP identifiers remain valid and aliases need no update.
+      # Fall back to generating a fresh suggestion if no usable prior slug exists.
+      # Two concurrent jobs may occasionally suggest the same identifier, but the
+      # unique constraint on projects.identifier will reject the second writer, and
+      # the job can be retried.
+      new_identifier = project.previous_semantic_identifier ||
+                       generator.suggest_identifier(project.name, exclude: detector.exclusion_set)
+
+      project.identifier = new_identifier
+      project.save!(validate: false)
+    end
+
+
+    def reset_stale_identifiers
+      # Fix WPs that contain identifier that doesn't match the current project prefix
+      #   (caused by renames or cross-project moves in classic mode)
+      WorkPackage
+        .where(project:)
+        .where.not(sequence_number: nil)
+        .where("identifier NOT LIKE ?", "#{project.identifier}-%")
+        .find_each { |wp| wp.update_columns(identifier: nil, sequence_number: nil) }
+    end
+
+    def backfill_missing_ids
+      WorkPackage.where(project:, sequence_number: nil).order(:id).find_each do |wp|
+        seq, identifier = project.allocate_wp_semantic_identifier!
+        wp.update_columns(sequence_number: seq, identifier:)
+      end
+    end
+
+    def seed_alias_table
+      slug_prefixes = project.slugs.pluck(:slug)
+      return if slug_prefixes.empty?
+
+      WorkPackage.where(project:).where.not(sequence_number: nil).in_batches do |batch|
+        alias_rows = batch.pluck(:id, :sequence_number)
+                          .product(slug_prefixes)
+                          .map { |(wp_id, seq), prefix| { identifier: "#{prefix}-#{seq}", work_package_id: wp_id } }
+        WorkPackageSemanticAlias.upsert_rows(alias_rows)
+      end
+    end
+  end
+end

app/services/project_identifiers/pending_projects_finder.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module ProjectIdentifiers
+  # Returns the set of project IDs that still need backfilling before the
+  # instance can be switched to semantic identifier mode. Three buckets:
+  #
+  # * projects whose identifier is not in valid semantic format
+  # * projects that have work packages with no sequence_number yet
+  # * projects that have work packages whose identifier doesn't match
+  #   the current project prefix (stale due to renames or cross-project moves)
+  class PendingProjectsFinder
+    def project_ids
+      projects_with_bad_identifier | projects_with_unsequenced_wps | projects_with_stale_wps
+    end
+
+    private
+
+    def projects_with_bad_identifier
+      WorkPackages::IdentifierAutofix::ProblematicIdentifiers.new.scope.ids.to_set
+    end
+
+    def projects_with_unsequenced_wps
+      WorkPackage.where(sequence_number: nil).distinct.pluck(:project_id).to_set
+    end
+
+    def projects_with_stale_wps
+      WorkPackage
+        .joins(:project)
+        .where.not(sequence_number: nil)
+        .where("work_packages.identifier IS DISTINCT FROM " \
+               "projects.identifier || '-' || work_packages.sequence_number::text")
+        .distinct.pluck(:project_id).to_set
+    end
+  end
+end

app/services/work_packages/identifier_autofix.rb

@@ -32,7 +32,10 @@ module WorkPackages
   module IdentifierAutofix
     def self.job_in_progress?
       GoodJob::Job
-        .where(job_class: WorkPackages::IdentifierAutofix::ApplyHandlesJob.name)
+        .where(job_class: [
+                 ProjectIdentifiers::ConvertInstanceToSemanticIdsJob.name,
+                 ProjectIdentifiers::BackfillProjectJob.name
+               ])
         .exists?(finished_at: nil)
     end
   end

app/services/work_packages/identifier_autofix/problematic_identifiers.rb

@@ -65,6 +65,15 @@ def scope
 
       delegate :count, to: :scope
 
+      # Returns a symbol classifying why the identifier violates the expected format,
+      # or nil if the identifier is format-valid. Pure in-memory check — no DB queries.
+      def format_error_reason(identifier)
+        FORMAT_RULES.each do |reason, check|
+          return reason if check.call(identifier, max_identifier_length)
+        end
+        nil
+      end
+
       # Returns a symbol classifying why the identifier is problematic.
       # Must handle all identifiers matched by #scope.
       def error_reason(identifier)
@@ -87,13 +96,6 @@ def not_fully_uppercased      = Project.where("identifier != UPPER(identifier)")
 
       def max_identifier_length = ProjectIdentifierSuggestionGenerator::IDENTIFIER_LENGTH[:max]
 
-      def format_error_reason(identifier)
-        FORMAT_RULES.each do |reason, check|
-          return reason if check.call(identifier, max_identifier_length)
-        end
-        nil
-      end
-
       def collision_error_reason(identifier)
         if in_use_identifiers.include?(identifier)
           :in_use

app/workers/work_packages/identifier_autofix/apply_handles_job.rb → app/workers/project_identifiers/backfill_project_job.rb

@@ -28,13 +28,9 @@
 # See COPYRIGHT and LICENSE files for more details.
 #++
 
-class WorkPackages::IdentifierAutofix::ApplyHandlesJob < ApplicationJob
-  # FIXME: The admin UI's job_in_progress? query and :change_in_progress state
-  # assume at most one active instance of this job at any given time.
-  # Enforce this with good_job_control_concurrency_with(perform_limit: 1)
-  # when the real migration body is implemented.
-  def perform
-    # FIXME: replace with actual project handle migration
-    sleep 5
+class ProjectIdentifiers::BackfillProjectJob < ApplicationJob
+  def perform(project_id)
+    project = Project.find(project_id)
+    ProjectIdentifiers::BackfillProjectService.new(project).call
   end
 end