Feature/agile 326 multiple active sprints without sharing#24191
Open
dombesz wants to merge 12 commits into
Open
Feature/agile 326 multiple active sprints without sharing#24191dombesz wants to merge 12 commits into
dombesz wants to merge 12 commits into
Conversation
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
EinLama
force-pushed
the
feature/agile-326-multiple-active-sprints-without-sharing
branch
from
3770dc0 to
5ded453
Compare
myabc
reviewed
Jul 10, 2026
EinLama
force-pushed
the
feature/agile-326-multiple-active-sprints-without-sharing
branch
from
5c4b8f4 to
447a1bb
Compare
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
EinLama
force-pushed
the
feature/agile-326-multiple-active-sprints-without-sharing
branch
from
d31ec11 to
b262276
Compare
EinLama
force-pushed
the
feature/agile-326-multiple-active-sprints-without-sharing
branch
from
b262276 to
8361ba1
Compare
sprint_sharing_changed? checks whether the key "sprint_sharing" appears
anywhere in the settings_change diff array. A project with MAS enabled
and settings={} (sprint_sharing never explicitly saved, reads as
'no_sharing') has nil in the raw store. An API call that explicitly
sends sprint_sharing='no_sharing' writes
{"sprint_sharing"=>"no_sharing"} into the store, making the key appear
in the diff — sprint_sharing_changed? returns true. The second guard
model.allow_multiple_active_sprints? is also true, so the validator adds
:locked_by_multiple_active_sprints and rejects the update — even though
the effective sprint_sharing value did not change. A project managed via
API that ever explicitly names no_sharing while MAS is on is permanently
locked out of non-MAS updates through the normal UpdateService path.
… during perform in order to avoid concurrent service call race conditions.
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/AGILE-326
What are you trying to accomplish?
Allow multiple sprints inside a project when the project settings permit this.
What approach did you choose and why?
The first commit introduces multiple sprints unconditionally for all the project sharing settings. The second commit adds the project setting called "Allow multiple active sprints" which restricts multiple sprints to projects where this setting is enabled.
The third commit moves the multiple sprints setting to a separate tab in the project settings and adds interaction between sharing and multiple sprints (e.g., deactivate one when the other is enabled).
Todo:
Merge checklist