Enhance pin rules anchor and normalization#7
Merged
Conversation
…code serde-rs/serde#1732 here a descripion of the issue
hiimjako
changed the title
hiimjako
force-pushed
the
enhance-pin-rules
branch
from
acdb07e to
4907940
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the pin rule functionality to support
StartsWithandContains. It also introduces normalization options for anchor validation:None: No normalization applied (default for backward compatibility).Stem: Applies stemming to both the pattern and the term.The pin rule structure was updated to include a dedicated
normalizationfield. Also, the Serde serialization and deserialization logic was adjusted to handle these new fields while maintaining backward compatibility for existingisrules.I've also made the
patternrequired, since if it was missing, the serializer/deserializer was already returning an error.See: oramasearch/oramacore#299