Return find_references results to caller#5
Open
metaleap wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the suggestion. I'm not sure how I feel about exposing implementation-specific details to user scripts. In this case, `find_references()` would be returning a table (or nil) of locations, which are composed of `uri` and then `range` tables with its own structure. I know these structures are documented in the LSP and probably will not change, but it doesn't feel right to forward that to the user. I think perhaps having a module option (e.g. `find_references_dialog = true`) and then changing the function to either print or show a filteredlist dialog is a better way to go about this. I'm not sure how you'd display the results in the filteredlist dialog though, especially when it comes to searching. Do you have any ideas?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that users can optionally hook up another handling than
ui._printtofind_referencesresults, yet the change is non-breaking. (So plain old normallsp.find_references()calls see no change in behavior.)(If you're curious, with this PR accepted, then in my case I'd later implement in my init.lua a
ui.dialogs.filteredlist-based handling of find_references results. =)