fixed transmission loss plotting#120
Conversation
| xlabel = 'Range (m)' | ||
| if xr[1]-xr[0] > 10000: | ||
| xr = (min(tloss.columns)/1000, max(tloss.columns)/1000) | ||
| xr = (env['rx_range'].min()/1000, env['rx_range'].max()/1000) |
There was a problem hiding this comment.
Is the problem that tloss.columns is not correctly populated? If so, perhaps that's the place to fix this?
There was a problem hiding this comment.
yes，'tloss.columns' is incorrect , but it was calculated by Acoustic Toolbox in fortran. Could only fix it in original package
There was a problem hiding this comment.
Fair. I suggest that we still make env optional (recommended), but pick up rx_range from it if it is specified. Works?
There was a problem hiding this comment.
Sorry for long time till now thatＩnoticed your reply but there are lots of works for me， I would try refix it in spare time.🥲🥲🥲
There was a problem hiding this comment.
No problem, I understand. All of us have day jobs to take care of in addition to contributing to open source projects.
|
We also need to replicate the same change in |
2 participants
Sir, the attribute of tloss maybe not correspond after computing the tloss, which leads to wrong x-axis when plotting , variable environment is needed.This is the submitted PR.