chore(flow-functionality): quarantine the auto-save-off spec as a recurrent flake (#1336) - #1338
Merged
Merged
Conversation
…urrent flake (#1336) `auto-save-off.spec.ts:59` flaked on the 2026-07-22 and 2026-08-06 dailies with the same signature — `locator.click: Timeout 45000ms exceeded` reopening the just-created flow through its `list-card-open-button`. Two same-signature occurrences inside the 30-day window is the recurrent-flake criterion, so the test is quarantined as prevention (CONTRIBUTING.md -> Triage protocol, step 2). The 2026-07-15 and 2026-07-16 hits carry a different signature and do not count toward it. Quarantine is both edits together: `@stable` removal alone only stops the daily, leaving the test red on the pr-validation impacted-specs gate, which selects by file diff rather than by tag (#871) — including this PR. `test.fixme` skips it in every context. Lifting the quarantine (remove `test.fixme` + restore `@stable`) is a deliverable of #1336, not of this PR. The QA-CHECKLIST bullets are untouched: the spec still exists and still carries a mirrored doc, so the coverage guard still requires them. Triage: #1330 (run 31093877484).
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR quarantines a recurrently flaky flow test by converting it to test.fixme and removing the @stable tag, so the spec stops generating noise in scheduled stable runs and in CI contexts that still select the file.
Changes:
- Quarantined the flaky manual-save test using
test.fixme(...). - Removed the
@stabletag from the quarantined test while keeping the remaining tags intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarantines
auto-save-off.spec.ts:59("user should be able to manually save a flow when the auto_save is off") as prevention, perCONTRIBUTING.md→ Triage protocol, step 2.Spun out of daily-failure triage #1330 (run 31093877484, 2026-08-06). The investigation is tracked in #1336 — this PR does not fix anything.
Why
Recurrent flake: same signature on two dailies inside the 30-day window.
TimeoutError: locator.click: Timeout 45000ms exceeded.TimeoutError: locator.click: Timeout 45000ms exceeded.The wait is a 45 s click on the just-created flow's
list-card-open-buttonon the flows list. The same test also has hits on 2026-07-15 and 2026-07-16 under a different signature — a different cause, not counted toward the criterion.Why both edits, not just the tag
@stableremoval alone only stops the daily.pr-validation.ymlselects specs by file diff, not by tag (#871) — so the test would still run red on the impacted-specs gate, starting with this very PR.test.fixmeskips it in every context, which is what makes the quarantine hold and this PR merge green.Not touched
QA-CHECKLIST.mdbullets: the spec still exists and still has a mirrored doc, socheck:checklist-coveragestill requires them. Generated blocks are regenerated on merge byupdate-coverage-summary.yml.CONTRIBUTING.md, the traceability record for a quarantine cycle is the triage issue + the dedicated issue + the restoration PR.Lifting the quarantine (remove
test.fixme+ restore@stable, re-validated) is a deliverable of #1336.🤖 Generated with Claude Code