test(playground): mark playground-shareable-url as @stable - #171
Merged
Conversation
Migrate setup from Simple Agent template to setupPlayground() so the test no longer depends on a starter template name. Document the actual gating contract (hasIO + ENABLE_PUBLISH) in the spec doc and mark the Shareable Playground row in QA-CHECKLIST.md as covered. Closes #147
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the long-term stability of the Shareable Playground URL e2e test by removing its dependency on a specific starter template name and aligning documentation/checklists with the actual gating behavior.
Changes:
- Migrated
playground-shareable-url.spec.tssetup to use the sharedsetupPlayground()helper (Chat Input → Chat Output) instead of selecting the “Simple Agent” template. - Added the
@stabletag to the Shareable Playground URL test and updated the corresponding spec documentation to reflect real gating (hasIO/ENABLE_PUBLISH). - Marked the Shareable Playground checklist item as covered in
QA-CHECKLIST.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/tests-automations/regression/core-functionality/playground/playground-shareable-url.spec.ts | Switches test setup to setupPlayground() and adds @stable tag. |
| QA-CHECKLIST.md | Marks Shareable Playground URL generation as covered. |
| docs/core-functionality/playground/playground-shareable-url.md | Updates tags and documents the hasIO/ENABLE_PUBLISH gating and relevant test IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…hareable-url-stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playground-shareable-url.spec.tssetup from the Simple Agent template tosetupPlayground(), removing the dependency on a starter template name (the gating contract ishasIO, satisfied by Chat Input → Chat Output).@stableto the test tags and updates the spec doc's External dependencies to describe the realhasIO/ENABLE_PUBLISHgating instead of the previous template-tied wording.QA-CHECKLIST.mdas covered ([-]→[x]).Closes #147
Validation pipeline (7 steps)
npm run typecheck— cleannpx eslinton the spec file — cleanplaywright-test-linterskill — checklist all green (imports, no false-positive patterns, expect/test ratio 6:1, getByTestId, tags, serial mode)npx playwright test ... --retries=0— 1 passed (9.9s)INTENTIONALLY_BROKEN_FORCE_FAIL) — failed with the actual/playground/{uuid}href shown in the error, then reverted--trace=on— trace generated; first step "create blank Chat Input → Chat Output flow" + Share dropdown interactions match the spec doc🚨 Backend Errorprinted during the runTest plan
--retries=0againstlangflowai/langflow-nightly:latest