fix(ci): increase wait and timeout in migration UI test_01_open_flow - #212
Merged
Conversation
3s wait was too short for the nightly flow editor to render in CI. Aligned with other tests (5s) and extended expect timeout to 20s. Also fixes .first -> .first() (Playwright Python method call syntax). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize the migration workflow UI test suite by giving the migrated flow editor more time to render in CI (addressing intermittent “element not found” failures in test_01_open_flow).
Changes:
- Increase the post-navigation wait in
test_01_open_flowfrom 3s to 5s to match the other migration UI tests. - Increase the visibility assertion timeout for the flow canvas from 15s to 20s.
- Update the locator “first element” access in the canvas visibility assertion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Verify the flow editor loaded (look for the canvas/reactflow area) | ||
| canvas = self.page.locator(".react-flow, [data-testid='rf__wrapper']") | ||
| expect(canvas.first).to_be_visible(timeout=15_000) | ||
| expect(canvas.first()).to_be_visible(timeout=20_000) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_01_open_flowwas failing withelement(s) not foundfor.react-flowafter migrating to nightly. The 3s wait was too short for the flow editor canvas to render in CI runners.Tests 02–06 all passed because they each navigate to the same URL with a 5s wait.
Fix
wait_for_timeoutfrom3000→5000ms (consistent with all other tests)expect(...).to_be_visibletimeout from15_000→20_000ms for extra CI headroomcanvas.first→canvas.first()(correct Playwright Python method call syntax)🤖 Generated with Claude Code