fix(ci): replace canvas CSS selector with URL check in test_01_open_flow - #217
Merged
Conversation
CSS class selectors (.react-flow, [class*='react-flow']) are brittle across ReactFlow version bumps. Replaced with a URL assertion (flow_id in URL) which is version-independent and verifies the page actually loaded the correct flow without redirecting to home or login. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… (visible) The previous selector body > * resolved to the <noscript> element first, which is never visible when JS is enabled — causing a timeout every run. Switch to body > div with state=attached so the check passes as soon as the React root div is present in the DOM. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_01_open_flowkept failing across multiple fix attempts because all CSS selectors for the flow canvas (.react-flow,[class*='react-flow'], node selectors) are tied to ReactFlow internals that change across library versions. Tests 02–06 pass because they use text/attribute selectors, not canvas CSS classes.Fix
Replaced the canvas visibility check with two version-independent assertions:
expect(self.page).to_have_url(re.compile(flow_id))— verifies the page didn't redirect to home/loginwait_for_selector("body > *")— verifies the page rendered content (not blank)This is resilient to any ReactFlow or Langflow UI refactors.
🤖 Generated with Claude Code