test(regression): promote edit-flow-name.spec.ts to @stable - #264
Merged
Conversation
Refactor the existing test to be CI-friendly and add @stable: - Replace 4 inline rename cycles with a `for` loop over a 2-name array. Idempotence of repeated renames is already proven at 2 cycles; the 3rd and 4th add ~15-30s to weekly runs with no diagnostic value. - Fix the tag list: drop `@components` (this is project-management, not component config) and add `@stable` + `@regression`. - Update the test title to reflect what it actually validates: the main page listing reflects the rename (the original title mentioned editing "on the main page", but no main-page context-menu rename is exercised — only header rename + listing verification). - ESLint --fix promoted `expect(await ...count()).toBe(1)` to the auto-waiting `await expect(...).toHaveCount(1)`. This is non-redundant with `flow-rename-header.spec.ts` (@stable) — that spec covers header-DOM commit + API PATCH/GET persistence, while this spec uniquely covers the main page listing reflecting the rename and re-opening a flow by its new name. QA-CHECKLIST: add a new bullet specifically for the listing-verification angle (leaving the existing "Edit flow name and description" bullet for flowSettings.spec.ts, which tests description + character limit).
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes edit-flow-name.spec.ts to @stable, consolidates 4 repetitive rename cycles into a 2-iteration loop, corrects the tag list, retitles the test to match its actual behavior, and adds a corresponding QA-CHECKLIST entry.
Changes:
- Refactors test body to a
forloop over 2 random names, replacing 4 inlined cycles. - Updates tags from
["@release", "@workspace", "@components"]to["@stable", "@release", "@workspace", "@regression"]and refines the test title; promotesexpect(...).count()toawait expect(...).toHaveCount(1). - Adds a QA-CHECKLIST bullet under §12.2 mapping the listing-verification angle to this spec.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/tests-automations/regression/core-functionality/project-management/edit-flow-name.spec.ts | Loop-based refactor, tag/title update, auto-waiting assertion |
| QA-CHECKLIST.md | New [x] bullet linking listing-verification coverage to this spec |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes `tests/tests-automations/regression/core-functionality/project-management/edit-flow-name.spec.ts` to `@stable`. Trims 4 rename cycles → 2 (loop), fixes the tag list, and adds a QA-CHECKLIST bullet for the unique coverage angle.
Why this spec is non-redundant
`flow-rename-header.spec.ts` (`@stable`) already covers:
`edit-flow-name.spec.ts` uniquely covers:
Changes
Test plan