test(regression): promote run-flow.spec.ts to @stable #268
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,132 +3,154 @@ import path from "path"; | |
| import { expect, test } from "../../../fixtures/fixtures"; | ||
| import { adjustScreenView } from "../../../helpers/ui/adjust-screen-view"; | ||
| import { awaitBootstrapTest } from "../../../helpers/other/await-bootstrap-test"; | ||
| import { getAuthToken } from "../../../helpers/auth/get-auth-token"; | ||
| import { zoomOut } from "../../../helpers/ui/zoom-out"; | ||
|
|
||
| test( | ||
| "user should be able to use Run Flow without any issues", | ||
| { tag: ["@stable", "@release", "@workspace", "@api", "@regression"] }, | ||
| async ({ page, request }) => { | ||
| if (!process.env.CI) { | ||
| dotenv.config({ path: path.resolve(__dirname, "../../../.env") }); | ||
| } | ||
|
|
||
| await awaitBootstrapTest(page); | ||
|
|
||
| try { | ||
| await page.waitForSelector('[data-testid="blank-flow"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page.getByTestId("blank-flow").click(); | ||
|
|
||
| await page.getByTestId("sidebar-search-input").click(); | ||
| await page.getByTestId("sidebar-search-input").fill("chat output"); | ||
| await page.waitForSelector('[data-testid="input_outputChat Output"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page | ||
| .getByTestId("input_outputChat Output") | ||
| .hover() | ||
| .then(async () => { | ||
| await page.getByTestId("add-component-button-chat-output").click(); | ||
| }); | ||
|
|
||
| await zoomOut(page, 2); | ||
|
|
||
| await page.getByTestId("sidebar-search-input").click(); | ||
| await page.getByTestId("sidebar-search-input").fill("chat input"); | ||
| await page.waitForSelector('[data-testid="input_outputChat Input"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page | ||
| .getByTestId("input_outputChat Input") | ||
| .dragTo(page.locator('//*[@id="react-flow-id"]'), { | ||
| targetPosition: { x: 100, y: 100 }, | ||
| }); | ||
|
|
||
| await page.getByTestId("sidebar-search-input").click(); | ||
| await page.getByTestId("sidebar-search-input").fill("text output"); | ||
| await page.waitForSelector('[data-testid="input_outputText Output"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page | ||
| .getByTestId("input_outputText Output") | ||
| .dragTo(page.locator('//*[@id="react-flow-id"]'), { | ||
| targetPosition: { x: 300, y: 300 }, | ||
| }); | ||
|
|
||
| await adjustScreenView(page); | ||
|
|
||
| await page | ||
| .getByTestId("handle-chatinput-noshownode-chat message-source") | ||
| .click(); | ||
|
|
||
| await page.getByTestId("handle-textoutput-shownode-inputs-left").click(); | ||
|
|
||
| await page | ||
| .getByTestId("handle-textoutput-shownode-output text-right") | ||
| .click(); | ||
| await page | ||
| .getByTestId("handle-chatoutput-noshownode-inputs-target") | ||
| .click(); | ||
|
|
||
| await page.getByTestId("icon-ChevronLeft").click(); | ||
|
|
||
| await expect(page.getByText("New Flow")).toBeVisible({ timeout: 10000 }); | ||
| await page.getByTestId("new-project-btn").click(); | ||
|
|
||
| await page.getByTestId("blank-flow").click(); | ||
|
|
||
| await page.getByTestId("sidebar-search-input").click(); | ||
| await page.getByTestId("sidebar-search-input").fill("run flow"); | ||
| await page.waitForSelector('[data-testid="flow_controlsRun Flow"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page | ||
| .getByTestId("flow_controlsRun Flow") | ||
| .hover() | ||
| .then(async () => { | ||
| await page.getByTestId("add-component-button-run-flow").click(); | ||
| }); | ||
|
|
||
| await page | ||
| .getByTestId("value-dropdown-dropdown_str_flow_name_selected") | ||
| .click(); | ||
|
|
||
| await page.getByTestId("refresh-dropdown-list-flow_name_selected").click(); | ||
|
|
||
| await page.waitForSelector("text=Loading", { timeout: 30000 }); | ||
| await page.waitForSelector("text=Select an option", { timeout: 30000 }); | ||
|
|
||
| await page | ||
| .getByTestId("value-dropdown-dropdown_str_flow_name_selected") | ||
| .click(); | ||
|
|
||
| await page.getByTestId("dropdown-option-0-container").click(); | ||
|
|
||
| await page.getByTestId(/^textarea_str_chatinput.*/).click(); | ||
| await page | ||
| .getByTestId(/^textarea_str_chatinput.*/) | ||
| .fill("THIS IS A TEST FOR RUN FLOW COMPONENT"); | ||
|
|
||
| await page.getByTestId("button_run_run flow").click(); | ||
| await page.waitForSelector("text=built successfully", { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| // Wait for and click the output inspection button using partial match | ||
| await page.waitForSelector('[data-testid^="output-inspection-"]', { | ||
| timeout: 30000, | ||
| }); | ||
|
|
||
| await page.locator('[data-testid^="output-inspection-"]').first().click(); | ||
|
|
||
| const value = page.getByPlaceholder("Empty"); | ||
|
|
||
| await expect(value).toHaveValue("THIS IS A TEST FOR RUN FLOW COMPONENT"); | ||
| } finally { | ||
| // Best-effort cleanup of the 2 flows created by the test. | ||
| // Uses the API for speed and to avoid cascading UI failures. | ||
| try { | ||
| const headers = { Authorization: await getAuthToken(request) }; | ||
| const listRes = await request.get("/api/v1/flows/", { headers }); | ||
| if (listRes.ok()) { | ||
| const body = await listRes.json(); | ||
| const items = (Array.isArray(body) ? body : body?.items ?? []).slice( | ||
| 0, | ||
| 2, | ||
| ); | ||
| for (const f of items) { | ||
| await request.delete(`/api/v1/flows/${f.id}`, { headers }); | ||
| } | ||
|
Collaborator
Author
There was a problem hiding this comment. Valid — fixed in b89103e. Same root issue as comment 1 (positional
Fix is the same pattern from PR #267:
Validated against the live API: 182 flows before the run, 182 after — the 2 captured IDs were deleted, nothing else was touched. |
||
| } | ||
| } catch { | ||
| // Cleanup is best-effort — do not mask original test failure. | ||
| } | ||
| } | ||
| }, | ||
| ); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid — fixed in b89103e. You're right that the object-form fallback used the wrong key (
body?.itemsvs the actualbody.flowsshape established bytests/helpers/flows/clean-all-flows.ts:33). The bug never bit because Langflow currently returns the array form on this endpoint, but a future change to the response shape would have silently skipped cleanup.The whole listing call is gone now — replaced with the same ID-scoping pattern landed in PR #267 (bulk-actions): the test captures the flow ID from
page.url()after eachblank-flow.click()and thefinallyblock iterates only those captured IDs. No more list-then-slice; no more object-form ambiguity.