chore(weekly-232): demote @stable on 2 tests broken by upstream Langflow changes - #272
Merged
Merged
Conversation
…w changes Both tests fail against the current Langflow nightly due to intentional upstream changes, not test bugs of our own logic: - webhook 404 test: Langflow PR #12845 flipped WEBHOOK_AUTH_ENABLE default to True, so unauthenticated POSTs now return 403 before the flow lookup. Fix tracked in #269. - provider-invalid-auth icon click: Langflow PR #13111 renamed the Model Providers icon from Brain to BrainCircuit. Fix tracked in #270. Removing @stable so weekly-stable stops opening duplicate issues until the fixes land. Tag re-added in the respective fix PRs. Closes #232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@stablefrom two tests that now fail againstlangflowai/langflow-nightly:latestdue to intentional upstream Langflow changes.weekly-stableworkflow so it stops opening duplicate failure issues every Monday until the fixes land.@stableis re-added there.Failing tests demoted
webhook-component-regression.spec.ts:258— POST to non-existent flow returns 404WEBHOOK_AUTH_ENABLEdefaults toTrue; unauth POST → 403 before flow lookupprovider-invalid-auth-error.spec.ts:84— clicksicon-Brainin Settings sidebarBrain→BrainCircuitThe 6 flaky tests from the same weekly run remain
@stable(single flake does not trigger demotion per the lifecycle rule). Investigation tracked in #271.Test plan
npm run typecheck— no errorsnpm run lint— 0 errors (pre-existing warnings unchanged)weekly-stablerun no longer reports these two tests as@stablefailuresCloses #232