Skip to content

Make JSONToken.String.makeString() public #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joannis merged 2 commits into from
Apr 27, 2026
Merged

Make JSONToken.String.makeString() public #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b1d89a
Initial plan
Copilot Apr 26, 2026
8e3cb02
Make JSONToken.String.makeString() public
Copilot Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/_NIOJSON/Core/Bounds.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extension UInt8 {
extension JSONToken.String {
/// Makes a String from a Span.
/// Assumes the length is checked against the bounds `self`
func makeString(from span: Span<UInt8>, unicode: Bool) -> String? {
public func makeString(from span: Span<UInt8>, unicode: Bool) -> String? {
let startOffset = start.byteOffset

if usesEscaping {
Expand Down Expand Up @@ -125,7 +125,7 @@ extension JSONToken.String {
extension JSONToken.String {
/// Makes a String from an Array.
/// Assumes the length is checked against the bounds `self`
func makeString(from bytes: [UInt8], unicode: Bool) -> String? {
public func makeString(from bytes: [UInt8], unicode: Bool) -> String? {
let startOffset = start.byteOffset

if usesEscaping {
Expand Down
Loading