Skip to content

fix: bad part name/id when generate/assemble markdown - #1928

Merged
degenaro merged 5 commits into
developfrom
fix/oscal-title-type
Sep 9, 2025
Merged

fix: bad part name/id when generate/assemble markdown#1928
degenaro merged 5 commits into
developfrom
fix/oscal-title-type

Conversation

@degenaro

@degenaro degenaro commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro
degenaro requested a review from a team as a code owner September 4, 2025 17:53
@degenaro

degenaro commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator Author

Try again.

@degenaro degenaro closed this Sep 4, 2025

@vikas-agarwal76 vikas-agarwal76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikas-agarwal76

Copy link
Copy Markdown
Member

@degenaro Why have you closed this PR?

Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro

degenaro commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Closure was pre-mature. Re-open.

@degenaro degenaro reopened this Sep 5, 2025
@degenaro degenaro self-assigned this Sep 5, 2025
@degenaro degenaro added the bug Something isn't working label Sep 5, 2025

@vikas-agarwal76 vikas-agarwal76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro

degenaro commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Test case added. Ready for (re-)review.

@degenaro
degenaro requested review from a team and vikas-agarwal76 September 5, 2025 11:02

@vikas-agarwal76 vikas-agarwal76 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro
degenaro requested review from a team, AleJo2995, jpower432 and mrgadgil and removed request for a team and mrgadgil September 8, 2025 10:35
@jpower432

Copy link
Copy Markdown
Member

@degenaro Is this fixing the reported bug in #1922?

@degenaro

degenaro commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator Author

@degenaro Is this fixing the reported bug in #1922?

@jpower432 Yes, fixes #1922 is the claim!

@jpower432 jpower432 linked an issue Sep 8, 2025 that may be closed by this pull request

@jpower432 jpower432 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro
degenaro merged commit 428d880 into develop Sep 9, 2025
15 checks passed
@degenaro
degenaro deleted the fix/oscal-title-type branch September 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid NCName Validation on Title Content

3 participants