Fix: Rev 4 to Rev 5

[sebastiantorrescodes]

Types of changes

• Hot fix (emergency fix and release)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation (change which affects the documentation site)
• Breaking change (fix or feature that would cause existing functionality to change)
• Release (develop -> main)

Quality assurance (all should be covered).

• [ X] My code follows the code style of this project.
• [ X] Documentation for my change is up to date?
• [ X] My PR meets testing requirements.
• [ X] All new and existing tests passed.
• [ X] All commits are signed-off.

Summary

Key links:

• Sonar coverage

Before you merge

• Ensure it is a 'squash commit' if not a release.
• Ensure CI is currently passing
• Check sonar. If you are working for a fork a maintainer will reach out, if required.

[degenaro]

Hi @sebastiantorrescodes I enabled the pipelines and they passed. However DCO is failing. See the slack channel for some info on signing. Also, @1aur was successful at signing - perhaps she can share with you.

[degenaro]

@sebastiantorrescodes Do you want to meet on Teams to move this PR forward? Soon or once semester ends?

[degenaro]

Hi @sebastiantorrescodes please ping here or on slack. When can we meet on Teams this week and try to finish this PR?

[degenaro]

@sebastiantorrescodes When I download your branch:

degenaro:trestle.sebastian-torres$ grep -r rev4
tests/data/yaml/bad_component_dup_uuid.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/bad_component_dup_uuid.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/bad_component_no_tz.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/bad_component_no_tz.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/good_component.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/good_component.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/good_component_diff_tz.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json
tests/data/yaml/good_component_diff_tz.yaml:        source: https://github.com/usnistgov/OSCAL/blob/v1.0.0-milestone3/content/nist.gov/SP800-53/rev4/json/NIST_SP-800-53_rev4_catalog.json

[degenaro]

The variable name should be changed to reflect REV5.

[degenaro]

Same as above.

[degenaro]

Hi @sebastiantorrescodes, could you please fix the variable names. See comments. Also, if you click on DCO it will tell you how to sign and get rid of this red X. Thx!

[degenaro]

Closing in favor of #2116