Skip to content

fix: preserve falsy values in list_utils helpers #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishi-jat wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix: preserve falsy values in list_utils helpers #2120

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96016d9
fix: preserve falsy values in list_utils helpers
rishi-jat Mar 6, 2026
2fb5054
Merge branch 'develop' into fix/list-utils-falsy-values
degenaro Mar 9, 2026
c2c4981
Merge branch 'develop' into fix/list-utils-falsy-values
degenaro Mar 9, 2026
7b9f6ec
Merge branch 'develop' into fix/list-utils-falsy-values
degenaro Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions trestle/common/list_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def deep_set(dic: Dict[str, Any], path: List[str], value: Any, pop_if_none: bool
for node in path[:-1]:
dic[node] = dic.get(node, {})
dic = dic[node]
if value or not pop_if_none:
if value is not None or not pop_if_none:
dic[path[-1]] = value
else:
dic.pop(path[-1], None)
Expand Down Expand Up @@ -184,8 +184,8 @@ def deep_append(dic: Dict[str, Any], path: List[str], value: Any) -> None:


def set_or_pop(dic: Dict[str, Any], key: str, value: Any) -> None:
"""Set if value is non-empty list or not None otherwise remove."""
if value:
"""Set if value is not None otherwise remove."""
if value is not None:
dic[key] = value
else:
dic.pop(key, None)
Loading