Updates and bug fixes - #269
Open
shred86 wants to merge 155 commits into
Open
Conversation
initial merge
fix issue with convert_texture
separate O4XP data from libraries when using PyInstaller
Add zoom level asterisk, erase cached data feedback and fix symlink bug
Fix issue with zone_list saving in tile configuration, save on exit and versioning
include gdal for linux
Use os.path.join for data path
Version 1.40.12
Version 1.40.13
Move tile.dem = DEM.DEM(...) from inside include_airports to the top of build_poly_file. The DEM has no data dependency on OSM data, but nesting the load after the OSM airport query meant any Overpass failure (timeout, 5xx) left tile.dem = None, crashing later include_water with AttributeError: 'NoneType' object has no attribute 'alt_vec'. Failure mode scaled with OSM query density, hitting India and China tiles disproportionately. Refs: #89
Commit d1f34a4 added the same macOS mouse-binding block to both Ortho4XP_Custom_ZL and Ortho4XP_Earth_Preview, including a binding to self.delPol. That method only exists on Ortho4XP_Custom_ZL, so opening the Tiles Collection / Earth preview window on macOS with Python <= 3.12 raised AttributeError in __init__ and the window never opened. Remove the stray binding; the Earth preview has no polygon-delete action. The scroll bindings the block legitimately provides are kept. Fixes #91 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fix Earth preview crash on macOS with Python <= 3.12 (nonexistent self.delPol binding)
Fix tile.dem=None crash when Overpass airport query fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up closing my other pull requests since I've continued to work on Ortho4XP in my fork and there's enough changes that it's becoming difficult to manage the changes across two base branches. I'm creating this pull request which will includes all of the updates I've made and I'll try my best to make sure I provide detailed documentation. I'm continuing to work on this so I'll keep updating the documentation as I go along.
At a high level, my focus has been on:
I've documented all of the changes in the read me.
Development Notes
self.v_with the same prefix.cfg_varsto its own module, O4_Cfg_Vars.pyTodo
loggerto catch exceptions.