Skip to content

Fix _tkinter.TclError when on MacOS - #283

Open
RemoteCTO wants to merge 3 commits into
oscarpilote:masterfrom
RemoteCTO:master
Open

Fix _tkinter.TclError when on MacOS#283
RemoteCTO wants to merge 3 commits into
oscarpilote:masterfrom
RemoteCTO:master

Conversation

@RemoteCTO

Copy link
Copy Markdown

The .trace method is (being) deprecated in favour of .trace_add, and references to "ButtonPress-2" are now "ButtonPress-3"

See the following for more info: https://github.com/orgs/Homebrew/discussions/5809

@w8sl

w8sl commented Jan 8, 2025

Copy link
Copy Markdown

Thank you for PR!

Usage of TCL9 is inconsistent at the moment. Python.org and
GitHub runners are still on TCL8. Therefore, it may be better to fix buttons as recommended in discussion:

if "dar" in sys.platform and tk.TkVersion < 9:
            self.canvas.bind("<ButtonPress-2>", self.scroll_start)
            self.canvas.bind("<B2-Motion>", self.scroll_move)
            self.canvas.bind("<Control-ButtonPress-2>", self.delPol)

@RemoteCTO

Copy link
Copy Markdown
Author

@w8sl - Ah yes good point, I'll flip it over to that instead.

NB: There is one weird quirk I'm noticing in my local version of this, which is that it doesn't seem to persist the last selected square when closing and re-opening the app. Though I can't confirm yet if it's related.

@w8sl

w8sl commented Jan 8, 2025

Copy link
Copy Markdown

Cannot reproduce. Tested patched version of O4XP on Sequoia with all latest requirements (no versions) with Python 3.11, 3.12, 3.13

@w8sl

w8sl commented Jan 8, 2025

Copy link
Copy Markdown

brew reinstall python-tk (to get fixed version)

shizumaat added a commit to shizumaat/Ortho4XP-novemberlima that referenced this pull request Jun 15, 2026
…ension

User ruling (2026-06-10): the 1.5% cap applies along the taxi CENTERLINE;
cross-axis diagonal chords are unregulated (ICAO Annex 14 / EASA
CS-ADR-DSN.D.265/.280) and inside-of-curve edges legitimately exceed the
cap.  All-pair/visibility chords had pinned high-speed exit junctions
flat (HECA oscarpilote#282 could not rise toward A4).

Built:
- _PER_AXIS_JUNCTIONS=True + the per-axis rule applied where junction
  constraints are actually built (_build_shape_constraints visibility
  path; the flag previously only touched the unused _build_edges path):
  along-axis pairs cap at the ARC between projections, cross-axis
  diagonals drop, ring-adjacent pairs survive.
- Curve-aware corridor distances: _junc_axis_arc supersedes shorter
  geodesics in _junc_geo_dist (hard bands, twist clamps, ties).
- RUNWAY-EXIT EXTENSION: chain termini at runway-touching junctions get
  a virtual HARD station at the runway contact; contact = the qualifying
  centerline's nearest runway intersection (extending ingest-cut ends
  straight) or the fan's THROAT vertex by in-junction geodesic when the
  apt.dat line cuts the corner (A4's line: 40 m in-junction where the
  fan flow runs ~190 m); value = runway edge interpolation; the virtual
  gap is recorded as a twist line source so the junction interior is
  painted; singletons survive when extended; extended singletons skip
  the anchor relax (it crushed A5 flat and left 3.9 m at the oscarpilote#284 seam).

MEASURED (HECA): junction oscarpilote#282 now carries the climb (59.4 throat ->
62.6 at A4's mouth, the user-specified behaviour); A4 7% -> 1.4%.
NOT shippable yet: A5/oscarpilote#283 unchanged (its far-mouth nodes were already
relief-crushed to 60.5 pre-corridor - different mechanism), oscarpilote#284 3.9 m,
new oscarpilote#302 3.7 m / oscarpilote#192 1.2 m, and the 05C dip regressed 107.9 -> 110.4
(virtual anchors changed the demand measurement).  Parked for tuning.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants