Misc changes 1#144
Merged
Merged
Conversation
…erations to puff using the option internal-force-puff-iterations, and it default back to what the original hardcoded value of 4.
…-flat-strategy. Tested for the basic iteration setup.
…fails as they do not provide negative m modes but are needed. This now utilizes the existing code block for producing negative m mode for NRHybSur3dq8, which was originally meant for NRSur approximants.
…n the force-puff-iterations argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to util_RIFT_pseudo_pipe.py, helper_LDG_Events.py, and lalsimutils.py.
util_RIFT_pseudo_pipe.py: allow users to provide the number of iterations to puff using the option internal-force-puff-iterations, and it defaults back to the original hardcoded value of 4.
helper_LDG_Events.py: fixed the bug in this code when using --propose-flat-strategy. Tested for the basic iteration setup.
lalsimutils.py: Inference using NRHybsur3dq8 (lalsimulation version) fails as they do not provide negative m modes, but are needed. This now utilizes the existing code block for producing negative m modes for NRHybSur3dq8, which was originally meant for NRSur approximants.