Skip to content

Purl type casing improvements #11489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sschuberth wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Purl type casing improvements #11489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8eec4b
style(model): Sort assertions in a test alphabetically
sschuberth Feb 25, 2026
1293e48
test(model): Add "pod" to cover all hard-coded PURL type cases
sschuberth Feb 25, 2026
93d4ec7
chore(model): Explicitly lowercase PURL types
sschuberth Feb 25, 2026
a3edda8
fix(model): Map the "maven" PURL type as-is
sschuberth Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions model/src/main/kotlin/utils/PurlExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,10 @@ fun Identifier.getPurlType(): String =
* Map a PURL type string to the corresponding ORT Identifier type string.
*/
internal fun purlTypeToOrtType(purlType: String): String =
when (purlType) {
when (purlType.lowercase()) {
"cargo" -> "crate"
"cocoapods" -> "pod"
"golang" -> "go"
"maven" -> "Maven"
else -> purlType
}

Expand Down
8 changes: 5 additions & 3 deletions model/src/test/kotlin/utils/PurlExtensionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,12 @@ class PurlExtensionsTest : WordSpec({

"purlTypeToOrtType()" should {
"return the correct ORT type for known PURL types" {
purlTypeToOrtType("maven") shouldBe "Maven"
purlTypeToOrtType("npm") shouldBe "npm"
purlTypeToOrtType("golang") shouldBe "go"
purlTypeToOrtType("cargo") shouldBe "crate"
purlTypeToOrtType("cocoapods") shouldBe "pod"
purlTypeToOrtType("golang") shouldBe "go"

purlTypeToOrtType("maven") shouldBe "maven"
purlTypeToOrtType("npm") shouldBe "npm"
}

"return the type as-is for unknown PURL types" {
Expand Down
Loading