fix(checker): add committer fields to dangerous workflow contex#4974
Closed
LoveChauhan-18 wants to merge 2 commits intoossf:mainfrom
Closed
fix(checker): add committer fields to dangerous workflow contex#4974LoveChauhan-18 wants to merge 2 commits intoossf:mainfrom
LoveChauhan-18 wants to merge 2 commits intoossf:mainfrom
Conversation
…exts Signed-off-by: Love Kumar Chauhan <lovechauhan6564@gmail.com>
Member
|
@LoveChauhan-18 — While we are happy to consider contributions from new contributors, this is the second time you've opened a PR:
I am closing this PR and issuing a warning: please do not do this again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
The dangerous workflow check (containsUntrustedContextPattern) does not flag
committer.nameandcommitter.emailfrom GitHub webhooks as untrusted. These fields can be easily controlled by attackers.What is the new behavior (if this is a feature change)?**
Added
committer.emailandcommitter.namefor both thehead_commitandcommits.*objects directly into the untrusted context regex.Which issue(s) this PR fixes
Fixes #4926
Special notes for your reviewer
Added the missing fields to the regex alongside the existing author checks and updated the dangerous_workflow_test.go fixture table with the corresponding cases.
Does this PR introduce a user-facing change?
No