Begin adding material CWE-74 (CWE-79 and CWE-94)#715
Open
david-a-wheeler wants to merge 1 commit intomainfrom
Open
Begin adding material CWE-74 (CWE-79 and CWE-94)#715david-a-wheeler wants to merge 1 commit intomainfrom
david-a-wheeler wants to merge 1 commit intomainfrom
Conversation
Here is a start add subclasses of CWE-74, specifically CWE-79 and CWE-94. CWE-79 is one of the most common vulnerabilities on the planet, including code written in Python, so saying *nothing* about it would be a mistake. This is complicated because the only proper solutions to CWE-79 are external modules, which are out of scope. However, I think it's reasonable to make it clear that you *cannot* solve this at scale with only the built-in modules, so you *must* think beyond it. I didn't try to fill in the examples, because I wanted to see if this was a reasonable direction first. Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Contributor
|
This PR is related issue #680, some related CWEs such as 184 in the process of getting moved to GitHub as part of #531 To help find code examples, see existing related rules:
Some of the CWEs in this PR rule have code examples or CVEs might have patches listed:
CWE-79: Improper Neutralization of Input During Web Page Generation('Cross-site Scripting') no python code on mitre but following CVEs listed:
CWE-94: Improper Control of Generation of Code ('Code Injection') has Python code examples on mitre.org and a bunch of CVEs, here only a few of the latest:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a start add subclasses of CWE-74, specifically CWE-79 and CWE-94. CWE-79 is one of the most common vulnerabilities on the planet, including code written in Python, so saying nothing about it would be a mistake.
This is complicated because the only proper solutions to CWE-79 are external modules, which are out of scope. However, I think it's reasonable to make it clear that you cannot solve this at scale with only the built-in modules, so you must think beyond it.
I didn't try to fill in the examples, because I wanted to see if this was a reasonable direction first.