Make defrecords public so they can be extended#14
Open
transducer wants to merge 1 commit into
Open
Conversation
Author
|
We found a workaround: I do think it would be nicer just to use Clojure and not Java interop to access the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We are using this library (thanks!) and want to add a new function to the implementations of
StorageClient, namelybucket-exists?. To do this now we have to create our ownStorageClientprotocol with the extra method, and then create twodeftypes that wrap the implementations ofFileSystemStorageClientandGCSStorageClient, and just dispatch to the functions of the client in this library. If would be much nicer if we could do this:Because the
defrecordis private this is not possible.This PR makes them public. Let me if you have any questions or concerns.
Kind regards,
Erwin