Add ARGS JSON body test configuration#35
Open
0xst3m wants to merge 1 commit intoowasp-modsecurity:mainfrom
Open
Add ARGS JSON body test configuration#350xst3m wants to merge 1 commit intoowasp-modsecurity:mainfrom
0xst3m wants to merge 1 commit intoowasp-modsecurity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing ARGS test cases (
CONF_002_TARGET_ARGS_A-GETandCONF_002_TARGET_ARGS_B-POST) only coverapplication/x-www-form-urlencodedbodies. This PR adds coverage for JSON request bodies, which are processed through a different code path viactl:requestBodyProcessor=JSON.Changes
Added
config_tests/CONF_009_TARGET_ARGS_JSON.yamlwhich tests:ARGS(any key) andARGS:foo(specific key)Content-Type: application/json@contains attackThe test sends
{"foo": "attack"}as the request body, relying on the existing JSON processor rule (id:200001inmodsecurity.conf) to populateARGSfrom the parsed JSON.Test Results
All 6 generated rules passed on
mod_security2(Apache)