auxflash-server: validate slot index to prevent out-of-bounds writes#2483
Merged
evan-oxide merged 1 commit intomasterfrom Apr 21, 2026
Merged
auxflash-server: validate slot index to prevent out-of-bounds writes#2483evan-oxide merged 1 commit intomasterfrom
evan-oxide merged 1 commit intomasterfrom
Conversation
evan-oxide
force-pushed
the
evan/auxflash-oob
branch
from
7561080 to
12454ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, you could try to write (or read) a slot index higher than the number of slots. If there was extra unused space on the flash chip past the slots, this bug would presumably let you write to the unused space. The grapefruit I tested on doesn't have unused space, so it reported a
QspiTransferError. Now with the bounds check added, it reportsInvalidSlotinstead.This would also have been fixed by #2296