Open
Conversation
- Remove the schema cache from the `oximeter_db::Client` and any references to it or tests of it. Use the database as the sole source of truth for schema, on every insertion. - Fixup tests to refer to DB instead of the cache where needed. - Fixes #10292 and add a regression test for it.
bnaecker
force-pushed
the
ben/remove-oximeter-schema-cache
branch
from
e3fb6c7 to
fd58c96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oximeter_db::Clientand any references to it or tests of it. Use the database as the sole source of truth for schema, on every insertion.oximetercollector cache prevents writing schema when the database moves #10292 and add a regression test for it.