Don't block Nexus startup on successful IP allowlist plumbing#10305
Draft
Don't block Nexus startup on successful IP allowlist plumbing#10305
Conversation
Collaborator
bnaecker
commented
Apr 22, 2026
bnaecker
commented
- Remove the default firewall rule for Nexus that allows HTTP(S).
- Add data migration that removes the rule from existing systems.
- Make IP allowlist plumbing best-effort on Nexus startup. This prevents blocking the Nexus external API servers from starting up if we fail to reach any sled. Instead, we rely on OPTE's builtin default-deny firewall rule to keep the API servers unreachable until the allowlist plumbing is done. That could happen right away, if the sled-agents are reachable, but it might not happen until another background task run. But all the Nexus instances running on reachable sleds will be available when it does run.
- Return all errors while propagating firewall rules to sleds. Fixes Handle multiple failures in sled-agent firewall rule requests #1791. Log these during Nexus external server startup, and in the background task, and also return them in the OMDB task details.
- Remove the default firewall rule for Nexus that allows HTTP(S). - Add data migration that removes the rule from existing systems. - Make IP allowlist plumbing best-effort on Nexus startup. This prevents blocking the Nexus external API servers from starting up if we fail to reach any sled. Instead, we rely on OPTE's builtin default-deny firewall rule to keep the API servers unreachable until the allowlist plumbing is done. That _could_ happen right away, if the sled-agents are reachable, but it might not happen until another background task run. But all the Nexus instances running on reachable sleds will be available when it does run. - Return all errors while propagating firewall rules to sleds. Fixes #1791. Log these during Nexus external server startup, and in the background task, and also return them in the OMDB task details.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.