Drop cubic fit for interpolated broadening#473
Draft
ajjackson wants to merge 6 commits intorelease-2.0.0from
Draft
Drop cubic fit for interpolated broadening#473ajjackson wants to merge 6 commits intorelease-2.0.0from
ajjackson wants to merge 6 commits intorelease-2.0.0from
Conversation
Contributor
Test Results 22 files - 25 22 suites - 25 18m 9s ⏱️ - 30m 59s For more details on these failures, see this check. Results for commit c7e604a. ± Comparison against base commit 6132c68. ♻️ This comment has been updated with latest results. |
We only really have/use cheby-log so not much point in making it a parameter. There is room for improvement, but this might not be the right API when it comes, anyway.
Member
Author
|
The summaries of differences in test data look reasonable. I'd like to do a bit of plotting/benchmarking first to be sure they aren't changing in the "wrong" direction away from non-approximated values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #282
width_fit,adaptive_fit,adaptive_error_fit