instrument view cut documentation#1851
Open
abuts wants to merge 7 commits intopace-neutrons:masterfrom
Open
Conversation
abuts
added
documentation
Member
Author
|
This contribution has been mainly merged by PR #1843 but some minor modifications are still remain to review. |
cmarooney-stfc
requested changes
Jan 27, 2026
Collaborator
cmarooney-stfc
left a comment
cmarooney-stfc
left a comment
There was a problem hiding this comment.
The changes in the documents look ok. But the PR description says this is for the actual algorithm changes in PR 1845, and that PR has been closed without merging. Please alter the description so we can ensure that the docs match the code
Member
Author
|
I have modified PR description, highlighting what changes are here and there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Re #1846
This PR contains user documentation describing
instrument_veiw_cutalgorithm.As it is useless without algorithm iteslt, it is buld on the basis of it so should be reviewed after Re #1845 is merged. In fact, the actual merge have been performed by PR #1843, so PR #1845 contains only the description of the things made to the code