feat: Add image pull secret to dbclean job#277
Merged
ChrisJBurns merged 1 commit intoJun 24, 2026
Conversation
Contributor
|
@toscott Appreciate the PR! Would you be able to add some ci tests just so we can guarantee all renders nicely. You'll also need to bump the helm chart too with a fix version. The CONTRIBUTING.md has information on how to do this. |
Contributor
Author
|
Sure thing. |
toscott
force-pushed
the
feat/db-clean-image-pull-secret
branch
from
June 24, 2026 15:32
eff4b09 to
6e503d0
Compare
Contributor
Author
|
Let me know if there is anything else I need to address on this one. Thanks! |
ChrisJBurns
approved these changes
Jun 24, 2026
Contributor
|
@toscott Much appreciated, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The db-clean cronjob did not include the imagePullSecret. We use a self hosted image cache which requires authentication. Since the cronjob reuses the broker image, it seems to make sense it should also reuse the imagePullSecret.