Conversation
…or each freq channel
merging with simonsobs master
Collaborator
Author
|
I also merged the simonsobs/master to this branch, leaving the modifications I've done in theoryforge_mflike. Everything else should be as in simonsobs/master |
Collaborator
Author
|
I actually removed the condition to fix the new calibration params to the default if they are not present in the .yaml file used for the run, since the default should be taken from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the function
_get_calibrated_spectrainserting also calibration factors for each frequencycal_93, cal_145, cal_225. In order to preserve the previous version of the code, I added these lines to fix the new factors to one if they are not given as inputs. There was no need to modify the syslibrary class.@paganol @mgerbino what do you think? Do you prefer having a different function?