fix(locs): guard against non-array locsPath param#165
Open
ArmaanjeetSandhu wants to merge 1 commit into
Open
Conversation
|
@ArmaanjeetSandhu is attempting to deploy a commit to the pajecawav's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A malformed
locsPathquery param can crash the LOC section with an unhandled render exception.LocsSectionparseslocsPathlike this:The
try/catchonly guards against invalid JSON. Valid JSON that isn't astring[]slips through andpathends up non-iterable, so[repo, ...path](breadcrumbs) andfor (const dir of path)(inuseLocs) throwTypeError: path is not iterable.Repro
Open any repo page and append one of these params:
?locsPath=42?locsPath=null?locsPath={}?locsPath="hi"h / i?locsPath=["src"]Since
locsPathis shareable in the URL, a hand-edited or stale link is enough to trigger it.Fix
Extract a
parseLocsPathhelper that returns the value only when it's an array of strings, and falls back to[]otherwise. No behavior change for well-formed paths.Testing
[]for42,null,true,{},{"a":1},"hello",[1,2],foo,null, and"", and passes["src","lib"]through unchanged.