Skip to content

Change TOKEN_MAX_AGE to accept timedelta and default to 15 minutes.#1233

Merged
jwag956 merged 1 commit into
mainfrom
lowage
May 30, 2026
Merged

Change TOKEN_MAX_AGE to accept timedelta and default to 15 minutes.#1233
jwag956 merged 1 commit into
mainfrom
lowage

Conversation

@jwag956

@jwag956 jwag956 commented May 30, 2026

Copy link
Copy Markdown
Collaborator

The config variable still accepts seconds (int) as well. This also (finally?) sets the default to something short - rather than 'never expire' - which out of the box is really bad.

@codecov

codecov Bot commented May 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.63%. Comparing base (3a24949) to head (b4402b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          43       43           
  Lines        5358     5360    +2     
=======================================
+ Hits         5285     5287    +2     
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jwag956
jwag956 force-pushed the lowage branch 2 times, most recently from 600bd08 to b17c67f Compare May 30, 2026 15:55
The config variable still accepts seconds (int) as well.
This also (finally?) sets the default to something short - rather than 'never expire' - which
out of the box is really bad.
@jwag956
jwag956 merged commit 680f940 into main May 30, 2026
20 checks passed
@jwag956
jwag956 deleted the lowage branch May 30, 2026 20:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant